Skip to content

Fix for movestat with files-with-dots #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for movestat with files-with-dots #141

wants to merge 3 commits into from

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Jun 3, 2025 •
edited
Loading

Per @michellefrazer:

I'm having a new related issue where movestat is interpreting seasons wrong again.

With names like GenCast-FP-1.0deg-e1_GenCast-FP-1.0deg-e1_stats_uwnd_corcmp_GLO_z_MAY.gif, the season is interpreted as P-1.
With names like GenCast_FP_1.0deg_e1_GenCast_FP_1.0deg_e1_stats_uwnd_corcmp_GLO_z_MAY.gif, the season is interpreted as P_1.

This PR was supposed to make the "season" everything after the last underscore, but it appears that somehow it is actually looking for a 3-character string before the first period.

I can of course avoid periods in my experiment names in future, but I'm wondering if the code should be changed to focus on the underscore instead of the period? Or look for the last period instead of the first one?

So I yelled at ChatGPT for a bit and this seems to do it.

@mathomp4 mathomp4 self-assigned this Jun 3, 2025
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 3, 2025
@mathomp4 mathomp4 requested a review from michellefrazer June 3, 2025 23:17
@mathomp4 mathomp4 mentioned this pull request Jun 3, 2025
Merged
michellefrazer
michellefrazer approved these changes Jun 4, 2025
View reviewed changes
Copy link

@michellefrazer michellefrazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on moving my current files (with periods in their names) and it worked great, thanks!

@mathomp4 mathomp4 marked this pull request as ready for review June 4, 2025 14:02
@mathomp4 mathomp4 requested review from a team as code owners June 4, 2025 14:02
@mathomp4
Copy link
Member Author

mathomp4 commented Jun 4, 2025

I tested it on moving my current files (with periods in their names) and it worked great, thanks!

Okay. I'll undraft now so @sdrabenh can evaluate and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellefrazer michellefrazer michellefrazer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@mathomp4 mathomp4

Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathomp4 @michellefrazer @sdrabenh